-
Notifications
You must be signed in to change notification settings - Fork 167
Fix: Remove Empty Anchor Link in Jump-To Menu on Reference Pages #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Could you please describe the purpose of the fixed “Details” link? Is it intended to navigate to another resource? When I click it, nothing happens. |
The |
When I press Shift+Tab on the "p5.Amplitude" link, I see a "Details" link (Details). However, clicking this link does not navigate to any section. |
Thanks! The fallback |
There is no longer a "Details" link element, but a new issue has appeared: now, when tabbing, the focus lands on the entire navigation container. You need to press Tab again to move into the actual navigation content. When the focus is on the navigation container, the screen reader announces all the content within the container at once. |
Hey @coseeian, Sorry for the delay. I took some time to properly check the issue and make sure I was fixing it the right way. I've now updated the code so that links with undefined labels are completely skipped, without falling back to the "Details" label. This makes sure there are no non-functional or confusing links in the jump-to menu anymore. Please check and let me know if there's anything else. Thanks! |
I have reviewed this PR and all the issues mentioned have been addressed. I think it’s OK. |
Summary
This PR resolves the accessibility issue reported in #881 by removing an empty link in the jump-to navigation on reference pages like
/reference/p5.sound/
. The issue was caused by aJumpToLink
with no label, resulting in a screen reader announcing only “link” with no context.Issue: Closes #881
What Was Changed
Modified ReferenceLayout.astro to:
categoryData.length === 1
.How to Test
/reference/p5.sound/