Auto Close issues #952
Merged
Auto Close issues #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fully unmount sketches that go out of frame
Fixes an accidental inclusion of an unnecessary field
3 tasks
|
Hi @NalinDalal , same feedback here as on the other PR, and also looks like the base is not correct. Please close this PR and open on that is based on |
|
ohh, okay makes sense |
ksen0
added a commit
that referenced
this pull request
Oct 3, 2025
* solves docs issue 837 for p5.js 2.x * Update version * Merge pull request #812 from processing/feat/perf Fully unmount sketches that go out of frame * add updated editor images for intro tutorials * update image paths and alt text for editor images in intro tutorials * update screenshots with consistent browser theme * fixed typo: frameCount is a variable not a function * Update p5.js to v1.11.7 * Set iframe srcdoc attribute to blank to prevent iframe navigation * submission for shapeSVG library * rename file * Update p5.js to v1.11.8 * Create Accessibility Issue template * Update 4.accessibility.yml * Update placeholders in 4.accessibility.yml * Update 4.accessibility.yml to remove extra "steps to reproduce field" Fixes an accidental inclusion of an unnecessary field * Add issue-closing workflow to main branch * remove extra things, another issue entertained so removed that * pr branch update --------- Co-authored-by: Dave Pagurek <[email protected]> Co-authored-by: Dave Pagurek <[email protected]> Co-authored-by: raclim <[email protected]> Co-authored-by: Axel <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: limzykenneth <[email protected]> Co-authored-by: Ms. Feng <[email protected]> Co-authored-by: kit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Changes:
introduced yml file to auto close issue
checkout for reference