-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Replaced redundant else if statement with else statement #8016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Amante' Woodley <[email protected]> Co-authored-by: Nia Perez <[email protected]> Co-authored-by: Kayla Bobo <[email protected]> Co-authored-by: Silas Morgan <[email protected]>
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
1725148
to
ad887d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks to @awood0727 and your team.
Thank you team! @awood0727 and team: could you create a matching PR on the @perminder-17 This would be ok to merge next week after 1.11.10 is released |
@ksen0, we opened the requested duplicate pull request. Thank you for reviewing our work. |
Resolves #6660
Changes:
In this pull request, my team, which includes @npNSU, @kaybcodes, @SilasVM, and I made a change to line 495, which addressed the error of JavaScript being only able to check for references and not values. I changed the else if statement to an else statement and deleted the conditions. Hopefully, this is not too similar to PR#6662, and it also makes the program run more efficiently by removing a redundant check.
Hey @limzykenneth and @davepagurek, we noticed you two have been working diligently to find a pull request that can resolve the issue. We saw a comment about breaking early. If you have any advice on that, we may be able to implement it. Please let us know what you think. Thank you both for all that you have done.
Screenshots of the change:

PR Checklist
npm run lint
passes