Skip to content

Legacy CLI to handle sketch paths with spaces. #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025
Merged

Legacy CLI to handle sketch paths with spaces. #1162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33f6e02
Allow spaces in filepath name by forwarding all arguments
toniab Jun 28, 2025
08bdd85
Still pass help as an argument so that Commander help is shown. (Remo…
toniab Jun 28, 2025
ddcf0c7
Merge branch 'processing:main' into main
toniab Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions app/src/processing/app/Processing.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,30 +59,22 @@ class LSP: SuspendingCliktCommand("lsp"){
}
}

class LegacyCLI(val args: Array<String>): SuspendingCliktCommand( "cli"){
override fun help(context: Context) = "Legacy processing-java command line interface"

class LegacyCLI(val args: Array<String>): SuspendingCliktCommand("cli") {
override val treatUnknownOptionsAsArgs = true

val help by option("--help").flag()
val build by option("--build").flag()
val run by option("--run").flag()
val present by option("--present").flag()
val sketch: String? by option("--sketch")
val force by option("--force").flag()
val output: String? by option("--output")
val export by option("--export").flag()
val noJava by option("--no-java").flag()
val variant: String? by option("--variant")
val arguments by argument().multiple(default = emptyList())

override suspend fun run(){
val cliArgs = args.filter { it != "cli" }
override suspend fun run() {
try {
if(build){
if (arguments.contains("--build")) {
System.setProperty("java.awt.headless", "true")
}
// Indirect invocation since app does not depend on java mode

Class.forName("processing.mode.java.Commander")
.getMethod("main", Array<String>::class.java)
.invoke(null, *arrayOf<Any>(cliArgs.toTypedArray()))
.invoke(null, arguments.toTypedArray())
} catch (e: Exception) {
throw InternalError("Failed to invoke main method", e)
}
Expand Down