Display Welcome to Beta once per revision #1203
Merged
+19
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catilac
commented
Aug 13, 2025
Comment on lines
145
to
148
| System.err.println("MOON DEBUG" + | ||
| Base.getRevision() + ", and lastBetaSeen is " + | ||
| lastBetaSeen + "."); | ||
|
|
There was a problem hiding this comment.
will remove this, i suppose
There was a problem hiding this comment.
Yep, feel free to use Messages.log that will be hidden for users and will give us valuable information when looking at the logs
catilac
commented
Aug 13, 2025
| @@ -61,7 +62,10 @@ class WelcomeToBeta { | |||
| val mac = SystemInfo.isMacFullWindowContentSupported | |||
| SwingUtilities.invokeLater { | |||
| JFrame(windowTitle).apply { | |||
| val close = { dispose() } | |||
| val close = { | |||
| Preferences.set("beta.last_beta_welcome_seen", getRevision().toString()) | |||
There was a problem hiding this comment.
i need a better key name. wondering your thoughts. should it be update.beta_welcome or something?
Stefterv
reviewed
Aug 13, 2025
| if(latest < Base.getRevision()){ | ||
| WelcomeToBeta.showWelcomeToBeta(); | ||
|
|
||
| String lastBetaSeenStr = Preferences.get("beta.last_beta_welcome_seen"); |
There was a problem hiding this comment.
I would say using Preferences.getInteger() would be a better choice here, to make sure it is never empty you can add the key to the defaults.txt in build/shared/lib/defaults.txt
Stefterv
changed the title
Stefterv
approved these changes
Aug 14, 2025
SableRaf
approved these changes
Aug 14, 2025
|
@all-contributors please add @catilac for code |
|
I've put up a pull request to add @catilac! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the Welcome to Beta screen to once per downloaded revision.
Closes #1198