Fix the issue with the pre-processor test #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SableRaf and I should do some archeological research into bug 1532 on the bugzilla archives |
|
@Stefterv Bug 1532 can be found at https://bugzilla.processing.org/1532 |
catilac
reviewed
Sep 11, 2025
catilac
requested changes
Sep 11, 2025
Adjusted expected exception position in ParserTests for bug1532 and removed QuickTime session initialization from bug1532.pde to reflect updated test requirements.
catilac
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the preprocessor made it no longer recognise the
quicktimekeyword in thebug1532.pdecausing the test to fail. As far as I can see this test was never intended to test for that situation but rather for some invalid syntax later on line 50 of that file.I cannot find anything about the
quicktimekeyword so I have just commented out the line with the new issue