Update Gemfile (progit:5a2ed7b7) #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takuya Noguchi <[email protected]>
tnir
added
dependencies
|
TBH, I don't care about this Gemfile. It is overwritten by the compilation scripts from https://github.com/progit/progit2-pub which are downloaded by the CI tasks. |
jnavila
requested changes
Jan 13, 2022
|
|
||
| gem 'asciidoctor-epub3', :git => 'https://github.com/asciidoctor/asciidoctor-epub3' | ||
| gem 'asciidoctor-pdf', '1.5.0.alpha.16' | ||
| gem 'asciidoctor-pdf-cjk', '~> 0.1.3' |
There was a problem hiding this comment.
Unless it has changed lately, you have to keep asciidoctor-pdf-cjk in order to be able to build a PDF with CJK chars. This requirement pulls other requirements on asciidoctor-pdf and asciidoctor
There was a problem hiding this comment.
Did you try to compile a PDF book with these settings?
|
Can you check you can push to the repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from https://github.com/progit/progit2/blob/5a2ed7b76cf2469e7a750f2adee4732c256a8c75/Gemfile
Signed-off-by: Takuya Noguchi [email protected]