-
Notifications
You must be signed in to change notification settings - Fork 10
Remove dependency on k8s.io/kubernetes
#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/cc @dgrove-oss |
I'm pretty sure I'll try to figure out some how to get those defaulters without the direct dependency. |
Looks like we can't get the defaulters through one of the published k8s modules so we will have to replicate the needed functionality instead. This will be a bit fragile, but appears to be unavoidable if we can't access the generated functions. |
Could we run |
It's annoying but not blocking, so we can leave it as if we think there isn't any "good" solution. Ideally these defaulters would be published as part of https://github.com/kubernetes/api. |
In the short term, I'm going to copy in the generated defaulter (and associated helpers) I'm using into our utils package as package-private functions. That will let us clean the dependency. Longer term, I'd like to kick off a discussion with the Kueue maintainers about whether they really need to use such a picky and fragile notion of equality. |
Sounds good, thanks. |
Fixes project-codeflare#142. We need the functionality provided by this code, but it is sadly k8s internal and not registered by the AddToScheme method of the approved API package.
Fixes #142. We need the functionality provided by this code, but it is sadly k8s internal and not registered by the AddToScheme method of the approved API package.
WHY
k8s.io/kubernetes
is not meant to be depended on as explain in kubernetes/kubernetes#79384.WHAT
This causes issues with some tools.
HOW
Replace the dependency:
appwrapper/pkg/utils/utils.go
Line 30 in 37ce35b
With the right one from
k8s.io/api/core/v1
.The text was updated successfully, but these errors were encountered: