Simplify PodTemplateSpec construction for Kueue #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change strategy for constructing the PodTemplateSpec for Kueue to eliminate reliance on the copied Kubernetes internal defaulter for PodSpec. Now, we just copy the subset of the PodTemplateSpec that is necessary for Kueue's construction of the Workload object. This eliminates most of the fields with complex defaulting behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change strategy for constructing the PodTemplateSpec for Kueue to eliminate reliance on the copied Kubernetes internal defaulter for PodSpec. Now, we just copy the subset of the PodTemplateSpec that is necessary for Kueue's construction of the Workload object. This eliminates most of the fields with complex defaulting behavior.