Skip to content

Redesign node monitoring to account for Node deletion #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

dgrove-oss
Copy link
Collaborator

  1. Split node monitoring into two reconcilers, one to monitor Nodes and one to monitor and update the designated slack ClusterQueue.
  2. Remove entries from in memory caches when a Node is deleted.
  3. Watch slack cluster queue to be able to react to changes in nominalQuotas and adjust lendingLimits accordingly.

Fixes #252.

1. Split node monitoring into two reconcilers, one to monitor Nodes
   and one to monitor and update the designated slack ClusterQueue.
2. Remove entries from in memory caches when a Node is deleted.
3. Watch slack cluster queue to be able to react to changes in
   nominalQuotas and adjust lendingLimits accordingly.

Fixes project-codeflare#252.
Copy link
Member

@tardieu tardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

Copy link
Member

@tardieu tardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dgrove-oss dgrove-oss merged commit cacf2c7 into project-codeflare:main Oct 16, 2024
3 checks passed
@dgrove-oss dgrove-oss deleted the nm-delete branch October 16, 2024 19:20
@dgrove-oss dgrove-oss added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LendingLimit bias when removing nodes from the cluster
2 participants