add: function to return machine pool labels

[VanillaSpoon]

Issue link

Adding this function to use when updating machinepool tests for this pr

What changes have been made

Addition of a label that returns if a machinepool contains a specified label key.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[Fiona-Waters]

/lgtm

[sutaakar]

@VanillaSpoon I am not much a fan of test functions returning bool.
What is the use case you want to use it in?

[VanillaSpoon]

Hi @sutaakar,
Thanks for the question. I was hoping to use the function with this pr. Checking for the existence of a machinepool with a label key matching the appwrapper used to scale up, before and after.

Although, if there is a preferred method, I am happy to update :)

[sutaakar]

@VanillaSpoon The problem with bool comparison like:

	test.Expect(GetMachinePools(test, connection)).
		Should(ContainElement(WithTransform(
			func(machinePool *cmv1.MachinePool) bool {
				return MachinePoolHasLabelKey(machinePool, "test-instascale")
			},
			BeFalse(),
		)))

is that in case of failure you get error message like "true is not false", which doesn't say much.

Better approach is to test for specific value.
So in this case it should be better to check list of keys, like (code untested):

	test.Expect(GetMachinePools(test, connection)).
		Should(ContainElement(WithTransform(MachinePoolLabelKeys, ContainElement("test-instascale"))))

while MachinePoolLabelKeys will return a slice of keys.

What do you think?

[VanillaSpoon]

@VanillaSpoon The problem with bool comparison like:

	test.Expect(GetMachinePools(test, connection)).
		Should(ContainElement(WithTransform(
			func(machinePool *cmv1.MachinePool) bool {
				return MachinePoolHasLabelKey(machinePool, "test-instascale")
			},
			BeFalse(),
		)))

is that in case of failure you get error message like "true is not false", which doesn't say much.

Better approach is to test for specific value. So in this case it should be better to check list of keys, like (code untested):

	test.Expect(GetMachinePools(test, connection)).
		Should(ContainElement(WithTransform(MachinePoolLabelKeys, ContainElement("test-instascale"))))

while MachinePoolLabelKeys will return a slice of keys.

What do you think?

Ooohhh I see! Thanks for the clarification, I can see how that's a hindrance.

I love it :) I'll make the adjustments now

[sutaakar]

/lgtm

[Fiona-Waters]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar, VanillaSpoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment