Migrate MCAD Custom Resources over to this repository #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

anishasthana opened this issue Mar 6, 2023 · 1 comment

Contributor

anishasthana commented Mar 6, 2023

Once the operator bundle is created for the CodeFlare Operator, subscribing to this operator will create the CRDs by default.

We should look into migrating https://github.com/project-codeflare/multi-cluster-app-dispatcher/tree/main/config/crd/bases over into this repository completely and changing mcad repository references to it to effectively be imports. An example of that would be https://github.com/kserve/modelmesh-serving/blob/main/controllers/servingruntime_controller.go#L38, which refers to https://github.com/kserve/kserve/tree/master/pkg/apis/serving/v1beta1

Alternatively, we need to come up with a better plan for keeping the 2 repositories in sync.

astefanutti mentioned this issue

Use Kustomize to bundle MCAD CRDs #116

Merged

Contributor

astefanutti commented Sep 25, 2023

This has practically been addressed with #116.

astefanutti closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment