add new github action which tags and builds a new operator #110
Conversation
|
Skipping CI for Draft Pull Request. |
Makefile
Outdated
| PREVIOUS_VERSION ?= 0.0.1 | ||
| VERSION ?= 0.0.2 |
There was a problem hiding this comment.
Ran make bundle -e PREVIOUS_VERSION=0.0.3 -e VERSION=0.0.4. No error.
To make the next release easier, should we preset the envs to:
| PREVIOUS_VERSION ?= 0.0.1 | |
| VERSION ?= 0.0.2 | |
| PREVIOUS_VERSION ?= 0.0.3 | |
| VERSION ?= 0.0.4 |
There was a problem hiding this comment.
What do you think about making them explicitly dev? Something like:
VERSION ?= 0.0.0-dev
PREVIOUS_VERSION ?= 0.0.0-dev # maybe even creating a conditional instead in the case that it is unset
There was a problem hiding this comment.
I think VERSION ?= 0.0.0-dev should be ok. PREVIOUS_VERSION may safer to be an existing bundle release judging by some examples here which implies the replaces is an version from an update graph which maybe built from existing CSVs.
.github/workflows/tag-and-build.yml
Outdated
| - name: Install operator-sdk | ||
| run: | | ||
| export ARCH=$(case $(uname -m) in x86_64) echo -n amd64 ;; aarch64) echo -n arm64 ;; *) echo -n $(uname -m) ;; esac) | ||
| export OS=$(uname | awk '{print tolower($0)}') | ||
| export OPERATOR_SDK_DL_URL=https://github.com/operator-framework/operator-sdk/releases/download/v1.27.0 | ||
| curl -LO ${OPERATOR_SDK_DL_URL}/operator-sdk_${OS}_${ARCH} | ||
| chmod +x operator-sdk_${OS}_${ARCH} && sudo mv operator-sdk_${OS}_${ARCH} /usr/local/bin/operator-sdk |
There was a problem hiding this comment.
Is there a reason not using make install-operator-sdk ?
There was a problem hiding this comment.
I was using an existing git action. https://github.com/project-codeflare/codeflare-operator/blob/main/.github/workflows/operator-image.yml I can see if I can do this the way that you suggested
There was a problem hiding this comment.
Hi @KPostOffice I don't know if I could test out the the git action because I don't have the credentials to the the Rh registry. Otherwise looks good just some nit picks.
Haven't tested yet. I will try the changes on my fork. |
KPostOffice
force-pushed
the
issue98-v1
branch
2 times, most recently
from
4899526 to
771b5a6
Compare
|
@KPostOffice I could not test the the new github workflow. The make bundle /lgtm |
|
What do folks think of switching over https://github.com/project-codeflare/codeflare-operator/blob/main/Dockerfile#L2 to be one of the registry.access.redhat.com/ubi8/go-toolset:1.18.9-8? That oughta get around the need to authenticate to the red hat registry. |
Signed-off-by: Kevin <[email protected]>
this makes the images easier to build for those outside of the red hat organization Signed-off-by: Kevin <[email protected]>
More than happy to do this. I can then also remove the auth step from the GitHub actions |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbusche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
fixes #98