Add Ray cluster REST API support in test support package #197
Conversation
|
seems that k8s api upgrade is too big change for a codebase, need to find compatible OpenShift client versions (dependency hell strikes back) |
sutaakar
force-pushed
the
ray-cluster
branch
3 times, most recently
from
d04b9b0 to
48f7ac5
Compare
sutaakar
force-pushed
the
ray-cluster
branch
2 times, most recently
from
3af0cee to
06b57b7
Compare
| return RayJobAPIDetails(t, rayClient, jobID)(t) | ||
| } | ||
|
|
||
| func WriteRayJobAPILogs(t Test, rayClient RayClusterClient, jobID string) { |
There was a problem hiding this comment.
I'd suggest to remove the GetRayJobLogs and WriteRayJobLogs functions from the ray.go file, that rely on the API server proxy, and have them replaced by these one, so there are used in the tests upstream as well.
For it to work, we can install the NGINX ingress controller in KinD (The KinD configuration already contains the "ingress-ready=true" kubelet extra argument), and create an Ingress resource in the TestMNISTRayJobMCADRayCluster test.
There was a problem hiding this comment.
Thinking about creating a follow up task for this. Not sure if I will have enough time to address it tomorrow, before my vacation.
There was a problem hiding this comment.
Yes, that sounds good. I can take of it 👍🏼.
There was a problem hiding this comment.
@astefanutti Created #199
|
/lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Part of opendatahub-io/distributed-workloads#63
What changes have been made
Adjustments in e2e test support package to provide support for new ODH integration test - opendatahub-io/distributed-workloads#71
Verification steps
The changes can be verified by running ODH integration test, see instructions in opendatahub-io/distributed-workloads#71
Checks
It is enough to run the local e2e tests (part of the PR check) to make sure nothing is broken.