Skip to content

Adjust SDK version, fix TestMNISTRayClusterSDK #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Adjust SDK version, fix TestMNISTRayClusterSDK #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ KUBERAY_VERSION ?= v0.5.0
RAY_VERSION ?= 2.5.0

# CODEFLARE_SDK_VERSION defines the default version of the CodeFlare SDK
CODEFLARE_SDK_VERSION ?= 0.4.4
CODEFLARE_SDK_VERSION ?= 0.6.1

# OPERATORS_REPO_ORG points to GitHub repository organization where bundle PR is opened against
# OPERATORS_REPO_FORK_ORG points to GitHub repository fork organization where bundle build is pushed to
Expand Down
5 changes: 2 additions & 3 deletions test/e2e/mnist_raycluster_sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,12 @@
cluster = Cluster(ClusterConfiguration(
name='mnist',
namespace=namespace,
min_worker=1,
max_worker=1,
num_workers=1,
min_cpus='500m',
max_cpus=1,
min_memory=0.5,
max_memory=1,
gpu=0,
num_gpus=0,
instascale=False,
))

Expand Down
3 changes: 3 additions & 0 deletions test/e2e/mnist_raycluster_sdk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ func TestMNISTRayClusterSDK(t *testing.T) {
test.T().Skip("Requires https://github.com/project-codeflare/codeflare-sdk/pull/146")
}

// Currently blocked by https://github.com/project-codeflare/codeflare-sdk/pull/271 , remove the skip once SDK with the PR is released
test.T().Skip("Requires https://github.com/project-codeflare/codeflare-sdk/pull/271")

// Create a namespace
namespace := test.NewTestNamespace()

Expand Down
2 changes: 1 addition & 1 deletion test/support/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package support
// ***********************

const (
CodeFlareSDKVersion = "0.4.4"
CodeFlareSDKVersion = "0.6.1"
RayVersion = "2.5.0"
RayImage = "rayproject/ray:2.5.0"
)