Skip to content

Update Job names so there is no overlap between e2e and olm CI #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anishasthana
Copy link
Contributor

In the last release we noticed that the PR got merged in even though the olm upgrade tests was failing (and the e2e test passed). We suspect it is due to the name of the jobs.

https://project-codeflare.slack.com/archives/C04SSHUB3GB/p1691775982411549

@sutaakar
Copy link
Contributor

/lgtm

Copy link
Collaborator

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Maxusmusti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6fdc333 into project-codeflare:main Aug 14, 2023
@anishasthana anishasthana deleted the update_job_names branch August 14, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants