Skip to content

Apply MCAD CRD version replace for operator uninstall and undeploy #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2023
Merged

Apply MCAD CRD version replace for operator uninstall and undeploy #236

merged 1 commit into from
Aug 17, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Aug 15, 2023 •
edited
Loading

Issue link

What changes have been made

make uninstall and make undeploy were missing MCAD CRD reference setter, the result was failing command due to wrong MCAD reference when calling affected commands.

Verification steps

Run make uninstall and make undeploy. Without this change the commands failed on wrong MCAD CRD version.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from anishasthana and jbusche August 15, 2023 06:42
ChristianZaccaria
ChristianZaccaria approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works perfectly! /lgtm 👍

@openshift-ci openshift-ci bot added the lgtm label Aug 16, 2023
dimakis
dimakis approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not verified it but changes LGTM

anishasthana
anishasthana reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sutaakar
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, dimakis, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 39225d3 into project-codeflare:main Aug 17, 2023
@sutaakar sutaakar deleted the uninstall-kfn branch August 17, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishasthana anishasthana anishasthana left review comments

@dimakis dimakis dimakis approved these changes

@ChristianZaccaria ChristianZaccaria ChristianZaccaria approved these changes

@jbusche jbusche Awaiting requested review from jbusche

Assignees

@anishasthana anishasthana

@dimakis dimakis

@ChristianZaccaria ChristianZaccaria

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sutaakar @anishasthana @dimakis @ChristianZaccaria @openshift-merge-robot