Use sed command to replace MCAD repo reference in Makefile

[sutaakar]

Issue link

What changes have been made

Kustomize fn run is using Docker. This approach is incompatible with OpenShift CI, which doesn't provide Docker environment.
To make operator deployment being OpenShift CI friendly (and to remove a need to have specifically Docker installed for various Makefile actions) replacing the function with sed command providing same functionality.

Verification steps

Execute for example make install without Docker.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[astefanutti]

I would expect changes in the config/crd/mcad/kustomization.yaml, are these missing?

[sutaakar]

@astefanutti
config/crd/mcad/kustomization.yaml contains placeholder, I have left there kustomize metadata as it doesn't block or affect anything
The value itself is replaced just when needed (deployment using Makefile or bundle build).

[astefanutti]

@sutaakar oh I see, my sed-fu is not as strong as yours :).

So it won't work on macOS out of the box. If we don't want to adjust the command depending on the OS, we can mandate gnu sed to be installed and used on macOS.

[sutaakar]

That would be the best :)

[astefanutti]

That would be the best :)

Maybe a quick note in the README can be added, WDYT?

[sutaakar]

@astefanutti added a note in readme

[astefanutti]

/lgtm

[astefanutti]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment