Fix E2E tests README #299
Merged
Fix E2E tests README #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiripetrlik
requested review from
astefanutti
and removed request for
MichaelClifford and
anishasthana
jiripetrlik
force-pushed
the
fix-e2e-tests-readme
branch
from
3353178 to
a2b881d
Compare
astefanutti
reviewed
Sep 21, 2023
astefanutti
reviewed
Sep 21, 2023
README.md
Outdated
| @@ -40,6 +40,7 @@ The e2e tests can be executed locally by running the following commands: | |||
| 2. Start the operator locally: | |||
|
|
|||
| ```bash | |||
| NAMESPACE=default make run | |||
| make run | |||
There was a problem hiding this comment.
It should be removed :)
jiripetrlik
force-pushed
the
fix-e2e-tests-readme
branch
from
fc49a3e to
616a1eb
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for the README for integration tests. After the recent changes the operator requires to specify NAMESPACE environment variable.