Skip to content

Set security context on test pod to avoid pod security warning #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Srihari1192
Copy link
Contributor

Issue link

closes #328

What changes have been made

Added security context on the test Pod to avoid PodSecurity warning when running TestMNISTRayClusterSDK on OpenShift FIPS enabled cluster

Verification steps

1.Setup the codeflare operator on cluster openshift with FIPS enabled mode(https://docs.openshift.com/container-platform/4.12/installing/installing-fips.html)
2. Run test TestMNISTRayClusterSDK and check whether warnings are showing while running the test
Note : Tested this test by removing skip in local on openshift cluster with FIPS enable mode

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Srihari1192 Srihari1192 force-pushed the setSecurityContext-328 branch from a487248 to e60ea49 Compare October 26, 2023 08:17
@openshift-ci openshift-ci bot removed the lgtm label Oct 26, 2023
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d851f67 into project-codeflare:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid PodSecurity warning when running TestMNISTRayClusterSDK on OpenShift
3 participants