Skip to content

Update GRPC version for CVE #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

anishasthana
Copy link
Contributor

Signed-off-by: Anish Asthana <[email protected]>
@jbusche
Copy link
Collaborator

jbusche commented Oct 24, 2023

It looks good - I tried building my own image from your branch, and subbed it into the csv, it seems to run fine.

Total amount of time for 20 appwrappers is: 142 seconds

versus quay.io/project-codeflare/codeflare-operator:v1.0.0-rc.4
Total amount of time for 20 appwrappers is: 143 seconds

Security scan with Twistlock unfortunately doesn't spot the grpc error, but if I use Grype I'm still seeing the CVE-2023-44487 but It's not really showing me detail of the cause:

NAME                    INSTALLED               FIXED-IN     TYPE       VULNERABILITY     SEVERITY 
stdlib                  go1.19.13                            go-module  CVE-2023-44487    High

Copy link
Collaborator

@jbusche jbusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, jbusche, tedhtchang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astefanutti,jbusche,tedhtchang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anishasthana anishasthana merged commit ff2a9db into project-codeflare:main Oct 24, 2023
@anishasthana anishasthana deleted the update_grpc branch October 24, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants