-
Notifications
You must be signed in to change notification settings - Fork 61
Added launch.json for local debugging with VSCode #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added launch.json for local debugging with VSCode #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bobbins228 Could you add an example on how you run local debugger with the launch.json in the https://github.com/project-codeflare/codeflare-operator/blob/main/CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just aded a few comments.
Checked out this PR and was able to run CFO locally via debugger in VSCode.
4d1a77d
to
6e680ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
6e680ea
to
779bfe7
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get a debugging session running with the given instructions. Thanks @Bobbins228
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Bobbins228 Thanks!
The reverse command is:
ref: https://stackoverflow.com/a/50222853 Did you find a better solution to make git ignore this custom changes? |
@ronensc That's odd I see what you mean. I included the |
AFAIK, once git tracks a file, you can't ignore it with |
I see I'll look into a way of handling this and if there isn't any other solution we'll go with an example file. Thanks for the feedback! |
Issue link
What changes have been made
Added launch.json file for local debugging of the CodeFlare Operator
Verification steps
Fill in the launch.json file with your kube config file path and namespace the CFO should be acting in.
Scale down the CodeFlare Operator deployment if it exists in your cluster.
The operator should be running locally with VSCode.
Checks