Skip to content

Regenerate CFO CRD manifests for release #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Regenerate CFO CRD manifests for release #389

merged 1 commit into from
Nov 1, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 1, 2023

Issue link

Fixes #388

What changes have been made

Manifest is generated as part of the release flow. It is declared as a separate step because its invocation as part of bundle generation is hidden - changes are reverted after bundle build.

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from dimakis and tedhtchang November 1, 2023 12:37
Copy link
Contributor

@dimakis dimakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2023
@openshift-ci openshift-ci bot merged commit 544d1e7 into main Nov 1, 2023
@sutaakar sutaakar deleted the manifest branch November 2, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCAD CRD reference is not updated in release workflow
3 participants