Remove accidental prefix for service account for mcad-controller-ray-… #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clusterrolebinding
ChristianZaccaria
approved these changes
Nov 24, 2023
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…clusterrolebinding
Issue link
Fixes #420
What changes have been made
Service account name in
mcad-controller-ray-clusterrolebindingaccidentally containedcodeflare-operator-prefix, this prefix should be provided later, during kustomize build.As a result the kustomize build using default profile wasn't able to replace Service account namespace, causing CFO deployed by default profile to fail processing Ingress resource.
Verification steps
Deploy CFO using
make deploy -e IMG=quay.io/project-codeflare/codeflare-operator:v1.0.0-rc.4. With this fix themcad-controller-ray-clusterrolebindingCRB resource points tocodeflare-operator-controller-managerSA using proper namespaceopenshift-operators.Checks