Adjust upgrade e2e test to pause Job before upgrade #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutaakar
requested review from
astefanutti and
Srihari1192
and removed request for
anishasthana and
tedhtchang
|
/lgtm |
|
/approve |
Srihari1192
approved these changes
Dec 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, Srihari1192 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Fixes #426
What changes have been made
This PR makes sure that Job created by AppWrapper is suspended, resumed by
TestMNISTCheckAppWrapperStatus. As a result the upgrade test is not dependent on operator upgrade timing, as upgraded operator is running whenTestMNISTCheckAppWrapperStatusis invoked.Verification steps
Verified by running upgrade e2e test.
Checks