Skip to content

Fix MCAD version in Makefile #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Dec 22, 2023

Issue link

N/A

What changes have been made

Remove alignment of go.mod dependencies from image build. Now the alignment will be done only for operator release.
Current behavior broke dev image build - https://github.com/project-codeflare/codeflare-operator/actions/workflows/operator-image.yml

Verification steps

Run make build.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 22, 2023
@sutaakar sutaakar marked this pull request as ready for review December 22, 2023 10:11
@openshift-merge-bot openshift-merge-bot bot merged commit 575ac74 into project-codeflare:main Dec 22, 2023
@sutaakar sutaakar deleted the mcad branch December 22, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants