Skip to content

Download MNIST dataset from specific location #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jan 10, 2024

Issue link

Fixing RHOAIENG-1439
Downloading script based on a code provided by @abhijeet-dhumal

What changes have been made

Pull MNIST dataset from location specified by parameter. This will allow us to provide alternative dataset location for disconnected environment.

Verification steps

Run e2e tests in disconnected environment.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0cf73e8 into project-codeflare:main Jan 24, 2024
@sutaakar sutaakar deleted the dataset branch January 25, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants