Skip to content

update: change CSV alm-examples to '' #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

VanillaSpoon
Copy link
Contributor

What changes have been made

During release, the community-operators-prod sync is failing with:

[static-tests : run-suite]     {
[static-tests : run-suite]       "type": "error",
[static-tests : run-suite]       "message": "CSV contains an invalid value for metadata.annotations.alm-examples",
[static-tests : run-suite]       "check": "check_required_fields"
[static-tests : run-suite]     },

this is due to the following check:

        ("metadata.annotations.alm-examples", re.compile(r".{30,}", re.DOTALL), True),

A resolution is to set alm-examples to ''

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@VanillaSpoon VanillaSpoon requested review from sutaakar and removed request for sutaakar January 19, 2024 16:39
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChristianZaccaria
Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChristianZaccaria ChristianZaccaria merged commit b584b5e into project-codeflare:main Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants