Skip to content

update: change CSV alm-examples #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VanillaSpoon
Copy link
Contributor

What changes have been made

During release, the community-operators-prod sync is failing with:

[static-tests : run-suite]     {
[static-tests : run-suite]       "type": "error",
[static-tests : run-suite]       "message": "CSV contains an invalid value for metadata.annotations.alm-examples",
[static-tests : run-suite]       "check": "check_required_fields"
[static-tests : run-suite]     },

this is due to the following check:

        ("metadata.annotations.alm-examples", re.compile(r".{30,}", re.DOTALL), True),

A resolution is to add an alm-examples for the AppWrapper CRD

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Signed-off-by: Eoin Gallinagh <[email protected]>
@VanillaSpoon VanillaSpoon requested review from ChristianZaccaria and astefanutti and removed request for sutaakar and KPostOffice January 22, 2024 11:21
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 89efe67 into project-codeflare:main Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants