Instascale E2E test for nodepools

[Fiona-Waters]

Issue link

Jira Issue

What changes have been made

An e2e test has been added to test the entire instascale flow on a ROSA Hosted Hypershift Cluster.

I have also included an update to the instaScaleJobAppWrapper function based on recent changes to the mnist.py script and other e2e tests.

Verification steps

• Provision a Hypershift Cluster
• Install RHODS via Operator Hub setting the CodeFlare stack to Managed
• Create a separate Instascale deployment using the current main branch to include recent updates regarding naming convention.
  • Make sure to add the instascale-ocm-secret in the default namespace.
• Install NFD operator with NodeFeatureDiscovery CR.
• Install NVIDIA operator with ClusterPolicy CR.
• Run/debug the test and confirm that it passes.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[VanillaSpoon]

Hey Fiona,
Just left a small comment for considerations, this would be up to you though :)

Tests run as exected :) \lgtm

[sutaakar]

/lgtm

[VanillaSpoon]

/lgtm :) thanks @Fiona-Waters

[sutaakar]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment