Skip to content

Raise KinD Ingress controller version to v1.9.6 for manual setup #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jan 31, 2024

Issue link

N/A

What changes have been made

Cherrypicking project-codeflare/codeflare-common#31 to apply change for manual KinD provision for manual tests.

Verification steps

Run make kind-e2e and check that Ingress is properly deployed.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from astefanutti and jbusche January 31, 2024 14:42
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thank you!

@sutaakar
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristianZaccaria, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f8839e9 into project-codeflare:main Jan 31, 2024
@sutaakar sutaakar deleted the ingress branch January 31, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants