Skip to content

e2e tests: Use test image from quay.io/project-codeflare/demo-images #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Feb 19, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-2617

What changes have been made

Using test image which doesn't need to download anything from internet. This will allow easy test execution in disconnected environment.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar requested review from astefanutti and removed request for KPostOffice and Fiona-Waters February 19, 2024 14:36
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2024
Copy link

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ac483fd into project-codeflare:main Feb 19, 2024
@sutaakar sutaakar deleted the test-image branch February 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants