Skip to content

fix(manifests): missing namespace in CM stack-config #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Apr 16, 2024

Issue link

introduced in change opendatahub-io@afe5bdc
cause error:
* field specified in var '{namespace ConfigMap.v1.[noGrp] {data.namespace}}' not found in corresponding resource
which prevent deployment in ODH operator

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3f1166c into project-codeflare:main Apr 16, 2024
7 checks passed
@sutaakar
Copy link
Contributor

@zdtsw Do you need this change to be propagated into https://github.com/opendatahub-io/codeflare-operator ?

@zdtsw
Copy link
Contributor Author

zdtsw commented Apr 16, 2024

@zdtsw Do you need this change to be propagated into https://github.com/opendatahub-io/codeflare-operator ?

yes, please, once odh-nightly is open to build it will be a problem for QE

@sutaakar
Copy link
Contributor

Done, backported to ODH and RHDS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants