Skip to content

add: raycluster oauth mutating webhook #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

VanillaSpoon
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/RHOAIENG-1991

What changes have been made

Add Mutating Webhook to add OAuth SideCar to RayCluster

Verification steps

Setup environment.
Build and Deploy the codeflare-operator

Ensure all configurations have been applied

From the sdk, create a raycluster

  • Ensure the raycluster is deployed correctly
  • Inspect the raycluster yaml to enusre the oauth configuraitons have been applied
  • Inspect the raycluster head node and ensure the oauth is running alongside it.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign astefanutti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VanillaSpoon VanillaSpoon changed the title add: mutating webhook add: raycluster oauth mutating webhook Apr 16, 2024
@@ -15,5 +15,9 @@ resources:
domain: codeflare.dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the domain needs to be fixed.

@VanillaSpoon VanillaSpoon marked this pull request as ready for review April 16, 2024 15:38
if !alreadyExists {
rayclusterlog.Info("Adding OAuth sidecar container")
// definition of the new container
newOAuthSidecar := corev1.Container{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it have sense to limit Resources for oauth container?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sutaakar
I feel this is a good idea, I'd be unsure of the limits to set, so I'll pull in @astefanutti :)

kind: Service
metadata:
name: webhook-service
namespace: openshift-operators
Copy link
Contributor

@sutaakar sutaakar Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be namespace: system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'll switch this :)

@KPostOffice
Copy link
Collaborator

Closing, included via #530

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants