-
Notifications
You must be signed in to change notification settings - Fork 61
Fix Unknown build info in CodeFlare operator log #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Unknown build info in CodeFlare operator log #528
Conversation
Makefile
Outdated
@@ -155,6 +155,15 @@ build: fmt vet ## Build manager binary. | |||
" \ | |||
-o bin/manager main.go | |||
|
|||
.PHONY: docker-build | |||
docker-build: fmt vet ## Build manager binary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we rename this directive. This is a little too similar to make image-build
which builds the container image and I can see it possibly causing a bit of confusion. Something like go-build-for-image
maybe, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KPostOffice I agree, I also had doubts about the command name, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the steps also :)
No longer seeing:
INFO setup Build info {"operatorVersion": "UNKNOWN", "mcadVersion": "UNKNOWN", "instaScaleVersion": "UNKNOWN", "date": "UNKNOWN"}
We now have:
INFO setup Build info {"operatorVersion": "1.4.0-62cef7e-dirty", "date": "2024-04-24 15:10"}
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4606269
into
project-codeflare:main
Issue link
https://issues.redhat.com/browse/RHOAIENG-118
What changes have been made
Fix Unknown build info in CodeFlare operator log
Verification steps
To test this PR you should modify Dockerfile, build your own image and add it to DSC
build the image using new makefile command:
docker build -t quay.io/username/imagename:tag
.If running on macOS, use:docker build --platform linux/amd64 -t quay.io/username/imagename:tag
push your docker image to your quay.io account
add your custom image to config/manager/params.env and push your changes to github
Inside your cluster, navigate to 'rhods' under DataScienceCluster. In the YAML file, under spec -> components, add the following devFlag:
Checks