Skip to content

RayCluster mTLS support #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 19, 2024
Merged

RayCluster mTLS support #537

merged 7 commits into from
Apr 19, 2024

Conversation

astefanutti
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from Bobbins228 and dimakis April 19, 2024 12:51
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from astefanutti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobbins228 @astefanutti
Added Mtls patch
56465a1 
(cherry picked from commit de2de96fc88022df783b637ccb145d1d73ba66ff)
@Bobbins228 @astefanutti
Added Ingress domain to validateHeadInitContainer
c0c0b16
@astefanutti astefanutti mentioned this pull request Apr 19, 2024
Closed
4 tasks
Bobbins228
Bobbins228 reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 19, 2024
VanillaSpoon
VanillaSpoon reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Unsure how to avoid this error at setup for the CFO:

│ 2024-04-19T15:20:26Z    ERROR    cert-rotation    could not refresh CA and server certs

But runs as expected.

@astefanutti
Copy link
Contributor Author

@VanillaSpoon the message is misleading but it worked.

@astefanutti astefanutti merged commit 1a0141e into project-codeflare:main Apr 19, 2024
12 of 15 checks passed
@astefanutti astefanutti deleted the pr-40 branch April 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanillaSpoon VanillaSpoon VanillaSpoon left review comments

@Bobbins228 Bobbins228 Bobbins228 left review comments

@dimakis dimakis Awaiting requested review from dimakis

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

@ChristianZaccaria ChristianZaccaria Awaiting requested review from ChristianZaccaria

@sutaakar sutaakar Awaiting requested review from sutaakar

Assignees

@VanillaSpoon VanillaSpoon

@Bobbins228 Bobbins228

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astefanutti @VanillaSpoon @Bobbins228 @openshift-merge-robot