Allow for custom CertGeneratorImage

[Fiona-Waters]

Issue link

RHOAIENG-6505

What changes have been made

I updated the CFO config to include an image to be used for cert creation in the init containers added by the CFO webhook. This is added so that in the case of a disconnected cluster there is not an extra image required.

Verification steps

• Install CodeFlare Operator from this branch, and provide a custom image in the codeflare-operator-config configMap adding the image to the kuberay configuration like this:

    kuberay:
      ingressDomain: ""
      mTLSEnabled: true
      rayDashboardOAuthEnabled: true
      certGeneratorImage: "registry.access.redhat.com/ubi9@sha256:770cf07083e1c85ae69c25181a205b7cdef63c11b794c89b3b487d4670b4c328"

• Restart the CFO pod.
• Create a raycluster using a demo notebook, and check that the init containers are using the image specified in the configmap and that the raycluster pods are created succesfully.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[KPostOffice]

Looks good, just a couple comments 👍🏻

[ChughShilpa]

@Fiona-Waters
One question, To use custom image, user needs to specify it in cluster config in demo-notebooks and then also need to update the same in codeflare-operator-config config-map ?

[Fiona-Waters]

@Fiona-Waters One question, To use custom image, user needs to specify it in cluster config in demo-notebooks and then also need to update the same in codeflare-operator-config config-map ?

The ray image specified in the cluster config in demo-notebooks will be the main ray image used. The one set in the config map will be used just for tls cert creation in the init containers. It can be the same image for both but it doesn't have to be.

[Bobbins228]

/lgtm
Working as expected nice work Fiona

[KPostOffice]

One small comment

[KPostOffice]

Suggested change

	mtLSEnabled: false
	mTLSEnabled: false

Why is this needed here?

[Fiona-Waters]

Updated. It is needed as the e2e test is out of date. Creating a follow on jira to cover this.

[Fiona-Waters]

https://issues.redhat.com/browse/RHOAIENG-7055

[KPostOffice]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment