Skip to content

Add new quickstart doc #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

Add new quickstart doc #552

merged 1 commit into from
May 31, 2024

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented May 10, 2024

Issue link

RHOAIENG-6660

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Depends on #550

@Ygnas Ygnas marked this pull request as draft May 10, 2024 14:57
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doc should be RHOAI leaning with ODH an alternate choice.
Also left a few nits

Awesome work so far Ignas!

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few comments.

Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Few nitpicks.

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just a couple more small things. Thanks Ignas.

@Ygnas Ygnas requested a review from Fiona-Waters May 15, 2024 11:44
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Fiona-Waters
Copy link
Contributor

Re-adding label after rebase.
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 16, 2024
@Ygnas Ygnas marked this pull request as ready for review May 31, 2024 08:27
@openshift-ci openshift-ci bot requested a review from Bobbins228 May 31, 2024 08:27
@openshift-ci openshift-ci bot removed the lgtm label May 31, 2024
@Ygnas Ygnas requested a review from Fiona-Waters May 31, 2024 08:31
@Fiona-Waters
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 31, 2024
@sutaakar
Copy link
Contributor

/lgtm

@sutaakar
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4eff35d into project-codeflare:main May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants