Skip to content

Comment out install/uninstall make targets #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

What changes have been made

  • Commented out make install/uninstall targets as not required. We should revert this commit once AppWrapper CRDs are required and available to install from our repository.

Verification steps

Run make install.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChristianZaccaria
Copy link
Contributor Author

Fixed pre-commit

@openshift-ci openshift-ci bot removed the lgtm label May 13, 2024
Copy link

openshift-ci bot commented May 13, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot bot merged commit ebab80a into project-codeflare:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants