Skip to content

CertGeneratorImage to reference registry.redhat.io #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Jun 6, 2024

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-8274

What changes have been made

  • CertGeneratorImage to reference registry.redhat.io

Verification steps

  • If the CodeFlare-Operator was previously installed, please delete the codeflare-operator-config configmap before re-installing.
  • Install CodeFlare-Operator from this branch
  • Create a raycluster using a demo notebook, and check that the init containers are using the image specified in the configmap and that the raycluster pods are created succesfully.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested a review from dimakis June 6, 2024 11:14
@sutaakar
Copy link
Contributor

sutaakar commented Jun 6, 2024

/lgtm

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sutaakar
Copy link
Contributor

sutaakar commented Jun 6, 2024

/approve

Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c31ff4c into project-codeflare:main Jun 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants