Skip to content

Update TLS certificate generation container image #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update TLS certificate generation container image #582

merged 2 commits into from
Jun 28, 2024

Conversation

astefanutti
Copy link
Contributor

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Bobbins228
Copy link
Contributor

/lgtm
Do we need to update codeflare common dependency? @sutaakar

@sutaakar
Copy link
Contributor

@Bobbins228 yes

@sutaakar
Copy link
Contributor

rebasing, lets see if it helps

@astefanutti astefanutti force-pushed the pr-42 branch 2 times, most recently from 0bf9013 to b5276af Compare June 28, 2024 14:00
@astefanutti astefanutti force-pushed the pr-42 branch 2 times, most recently from 3c13deb to 88f1875 Compare June 28, 2024 14:47
@Bobbins228
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 28, 2024
Copy link

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti astefanutti merged commit fa186c2 into main Jun 28, 2024
10 checks passed
@astefanutti astefanutti deleted the pr-42 branch June 28, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants