Skip to content

Added conditions before deleting template elements #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Added conditions before deleting template elements #244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d313a04
Added conditions before deleting template elements
Bobbins228 Jul 25, 2023
bb34994
Updated conditions for generic items
Bobbins228 Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 55 additions & 20 deletions src/codeflare_sdk/utils/generate_yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,26 +266,61 @@ def enable_local_interactive(resources, cluster_name, namespace):


def disable_raycluster_tls(resources):
del resources["GenericItems"][0]["generictemplate"]["spec"]["headGroupSpec"][
"template"
]["spec"]["volumes"]
del resources["GenericItems"][0]["generictemplate"]["spec"]["headGroupSpec"][
"template"
]["spec"]["containers"][0]["volumeMounts"]
del resources["GenericItems"][0]["generictemplate"]["spec"]["headGroupSpec"][
"template"
]["spec"]["initContainers"]
del resources["GenericItems"][0]["generictemplate"]["spec"]["workerGroupSpecs"][0][
"template"
]["spec"]["volumes"]
del resources["GenericItems"][0]["generictemplate"]["spec"]["workerGroupSpecs"][0][
"template"
]["spec"]["containers"][0]["volumeMounts"]
del resources["GenericItems"][0]["generictemplate"]["spec"]["workerGroupSpecs"][0][
"template"
]["spec"]["initContainers"][1]
del resources["GenericItems"][3] # rayclient route
del resources["GenericItems"][2] # ca-secret
generic_template_spec = resources["GenericItems"][0]["generictemplate"]["spec"]

if "volumes" in generic_template_spec["headGroupSpec"]["template"]["spec"]:
del generic_template_spec["headGroupSpec"]["template"]["spec"]["volumes"]

if (
"volumeMounts"
in generic_template_spec["headGroupSpec"]["template"]["spec"]["containers"][0]
):
del generic_template_spec["headGroupSpec"]["template"]["spec"]["containers"][0][
"volumeMounts"
]

if "initContainers" in generic_template_spec["headGroupSpec"]["template"]["spec"]:
del generic_template_spec["headGroupSpec"]["template"]["spec"]["initContainers"]

if "volumes" in generic_template_spec["workerGroupSpecs"][0]["template"]["spec"]:
del generic_template_spec["workerGroupSpecs"][0]["template"]["spec"]["volumes"]

if (
"volumeMounts"
in generic_template_spec["workerGroupSpecs"][0]["template"]["spec"][
"containers"
][0]
):
del generic_template_spec["workerGroupSpecs"][0]["template"]["spec"][
"containers"
][0]["volumeMounts"]

for i in range(
len(
generic_template_spec["workerGroupSpecs"][0]["template"]["spec"][
"initContainers"
]
)
):
if (
generic_template_spec["workerGroupSpecs"][0]["template"]["spec"][
"initContainers"
][i]["name"]
== "create-cert"
):
del generic_template_spec["workerGroupSpecs"][0]["template"]["spec"][
"initContainers"
][i]

updated_items = []
for i in resources["GenericItems"][:]:
if "rayclient-deployment-name" in i["generictemplate"]["metadata"]["name"]:
continue
if "ca-secret-deployment-name" in i["generictemplate"]["metadata"]["name"]:
continue
updated_items.append(i)

resources["GenericItems"] = updated_items


def write_user_appwrapper(user_yaml, output_file_name):
Expand Down