Skip to content

Remove appwrapper yaml #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove appwrapper yaml #366

wants to merge 2 commits into from

Conversation

dimakis
Copy link
Contributor

@dimakis dimakis commented Oct 3, 2023

Issue link

closes #365

What changes have been made

Motivation:
A request to abstract away complexities and to make the SDK the core focus of interaction for users.

  • The moving of writing appwrapper to file by attribute passed instead of default.
  • .up() now reads the appwrapper from memory instead of opening yaml

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

…efault

Allows for the passing of `write_to_file` bool attribute to write the appwrapper to local dir
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dimakis
Copy link
Contributor Author

dimakis commented Oct 3, 2023

@KPostOffice @MichaelClifford @Maxusmusti

The following unit tests fail:

tests/unit_test.py::test_AWManager_creation FAILED
tests/unit_test.py::test_AWManager_submit_remove FAILED

I'm not sure, the test.yaml file is present. can one of you help?

@dimakis dimakis closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK saves Appwrapper yaml to ~/.codeflare/appwrapper/<aw.yml>
1 participant