Skip to content

Updated go version for e2e Workflow #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Bobbins228
Copy link
Contributor

Issue link

Brought on by failing e2e tests

What changes have been made

Updated the go version in the e2e test workflow

Verification steps

The workflow should pass now.
See passing example wf

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Sorry, something went wrong.

Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bobbins228. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR can be closed in favour of: project-codeflare/codeflare-operator#494

The e2e failure in the SDK is from the workflow on deploying the CFO.

The controller-runtime setup-envtest dependency was causing issues, we were initially always using the latest, but we'll have to stick to a release for now until we are able to upgrade go to 1.22 on the CFO. The fix on the CFO repo will fix e2e test here too.

@Bobbins228 Bobbins228 closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants