Skip to content

Fix incorrect comment to stop job in 1_cluster_job_client.ipynb #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented May 30, 2024

Issue link

What changes have been made

Correcting wrong comment to stop Ray job.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from Bobbins228 and KPostOffice May 30, 2024 09:03
@sutaakar sutaakar requested a review from Fiona-Waters May 31, 2024 12:00
@Fiona-Waters
Copy link
Contributor

@sutaakar pr needs rebase, then we can merge. Thanks

@sutaakar sutaakar force-pushed the sutaakar-patch-1 branch from 4afdffa to 86d5d47 Compare May 31, 2024 12:04
@sutaakar
Copy link
Contributor Author

rebased

@Bobbins228
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@Fiona-Waters
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@Fiona-Waters
Copy link
Contributor

rebased

Looks like it needs to be rebased again as another PR got merged just ahead of it.

@sutaakar sutaakar force-pushed the sutaakar-patch-1 branch from 86d5d47 to 3420029 Compare May 31, 2024 12:46
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 56b4478 into main May 31, 2024
5 checks passed
@sutaakar sutaakar deleted the sutaakar-patch-1 branch May 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants