Skip to content

add provision to delete kueue resources created during test #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Jun 5, 2024

Issue link

RHOAIENG-7684

What changes have been made

  • Added support method to delete kueue resources
  • Updated kueue resource creation flow to create resources using unique name for avoiding naming conflicts and to execute tests parallely
  • Updated e2e + upgrade tests to delete kueue resources created during test execution.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@abhijeet-dhumal abhijeet-dhumal marked this pull request as draft June 5, 2024 06:34
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-kueue-deletion branch 2 times, most recently from ca64d93 to e05d424 Compare June 5, 2024 07:20
@abhijeet-dhumal abhijeet-dhumal requested a review from sutaakar June 5, 2024 09:35
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-kueue-deletion branch 2 times, most recently from 4e018da to 1172cfb Compare June 5, 2024 11:14
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review June 5, 2024 11:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link
Contributor

@Srihari1192 Srihari1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@astefanutti
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
…name for avoiding naming conflicts and to execute tests parallely
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@astefanutti
Copy link
Contributor

/lgtm

@Srihari1192
Copy link
Contributor

@abhijeet-dhumal Can you add kueue deletion for appwrapper tests too

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, jiripetrlik, Srihari1192, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8cfcbde into project-codeflare:main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants