Skip to content

Update existing tests for disconnected automation #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Jun 24, 2024

Issue link

RHOAIENG-8735

What changes have been made

  • Updated existing tests to support disconnected testing
  • Added YAML file and support methods for S3 compatible storage instance deployment.
  • Added readme documentation for disconnected environment setup.

Verification steps

Make sure you have following pre-requisites setup for your disconnected cluster :

  1. Mirror registry : Make sure you have this minio image mentioned in deployment yaml present mirror registry - For example :
quay.io/minio/minio@sha256:08dbb97c6ddcbd15138fdbd258137c4ddac5c72fdd1994a9b2d42255a98fc77b 
  1. Minio storage instance : In case you don't have storage instance configured, can use disconnected_support.py file's apply_k8s_yaml and delete_k8s yaml methods using minio-deployment.yaml (Store MNIST datasets in a storage bucket similar to example shown below)
  2. Pypi mirror index : To install python package requirements as a part of rayjob.
  3. Export environment variables in below mentioned format :
export RAY_IMAGE=quay.io/project-codeflare/ray@sha256:72b9972b4c9fd39bfd8a1450d8227890fbda75425859a710f3514f17412ae20f \
PIP_INDEX_URL=https://bastion.dis-210gpu.aws.rhaiseng.com:9443/root/pypi/+simple/ \
PIP_TRUSTED_HOST=bastion.dis-210gpu.aws.rhaiseng.com \
MINIO_ENDPOINT=bastion.dis-210gpu.aws.rhaiseng.com:9000 \
MINIO_ACCESS_KEY=minioadmin \
MINIO_SECRET_KEY=minioadmin \
MINIO_STORAGE_BUCKET=dw-datasets \
AWS_STORAGE_BUCKET_MNIST_DIR=mnist-datasets

image

Run :
poetry run pytest -v -s ./tests/e2e/mnist_raycluster_sdk_oauth_test.py

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the disconnected-setup branch 2 times, most recently from 7aa7285 to b444d4b Compare June 24, 2024 13:19
@abhijeet-dhumal abhijeet-dhumal force-pushed the disconnected-setup branch 4 times, most recently from 1cb5e49 to f192abd Compare June 28, 2024 12:08
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2024
@abhijeet-dhumal abhijeet-dhumal changed the title Add raycluster-sdk oauth test case for disconnected cluster setup Update existing tests for disconnected cluster setup Jul 1, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the disconnected-setup branch 3 times, most recently from 9a4c515 to cfce0f6 Compare July 1, 2024 11:21
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review July 1, 2024 11:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2024
@openshift-ci openshift-ci bot requested a review from Maxusmusti July 1, 2024 11:25
@abhijeet-dhumal abhijeet-dhumal force-pushed the disconnected-setup branch 2 times, most recently from 582ec63 to de840c5 Compare July 5, 2024 07:58
@abhijeet-dhumal abhijeet-dhumal marked this pull request as draft July 9, 2024 05:29
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@abhijeet-dhumal abhijeet-dhumal changed the title Update existing tests for disconnected cluster setup Update existing tests for disconnected automation Jul 18, 2024
@abhijeet-dhumal abhijeet-dhumal force-pushed the disconnected-setup branch 8 times, most recently from 647cc4e to 47969a1 Compare July 19, 2024 13:06
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review July 19, 2024 13:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
… to download MNISt datasets for disconnected automation
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Srihari1192, sutaakar
Once this PR has been reviewed and has the lgtm label, please assign dimakis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhijeet-dhumal abhijeet-dhumal merged commit 88577c7 into project-codeflare:main Jul 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants