Adding tls cert creation and updating num workers in hf notebook #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fiona-Waters
requested review from
jiripetrlik
and removed request for
astefanutti and
Maxusmusti
jiripetrlik
approved these changes
Jul 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, jiripetrlik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 1d889b1
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Follow up after QE testing of RHOAIENG-6475
What changes have been made
Adding tls cert creation cell to the hf interactive demo notebook, updating the number of workers specified in the scaling config to match cluster config as well as updating the cluster_name parameter to match a recent update to other notebooks.
Verification steps
Checks