Skip to content

Add optimised Dependabot #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianZaccaria
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria commented Jul 31, 2024

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-10779

What changes have been made

This is to update requirements.txt files in the guided-demos, and e2e directories. PRs will be grouped to together to allow for consistency throughout common dependencies.

This will also update dependencies in poetry.lock and pyproject.toml files.

Dependabot does not yet offer the feature neither a workaround to exclude directories. For this reason, as a workaround I had to move the custom-nb-image/requirements.txt file to its own directory to exclude it.
Issue: dependabot/dependabot-core#4364

Verification steps

PRs in my fork:

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@ChristianZaccaria ChristianZaccaria changed the title Add optimised dependabot Add optimised Dependabot Jul 31, 2024
@ChristianZaccaria ChristianZaccaria force-pushed the add-dependabot-copy branch 3 times, most recently from 60be92e to aa7ce38 Compare August 1, 2024 08:52
Copy link
Contributor

@VanillaSpoon VanillaSpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Very nifty work around @ChristianZaccaria !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@Bobbins228
Copy link
Contributor

/lgtm /approve

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 🤦

Copy link
Contributor

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3f39521 into project-codeflare:main Aug 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants