Skip to content

Updating ray image to use sha rather than floating tag #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Fiona-Waters
Copy link
Contributor

Issue link

Related to RHOAIENG-12186

What changes have been made

Updating Ray image references to http://quay.io/modh/ray@sha256:83084b89885232e5733027b2ee45b83d3642ce32ae0b8e18b79ed45b6e734283 using static SHA tag rather than floating tag used previously - this is of benefit specifically in a disconnected environment.

Verification steps

  • Run the interactive demo notebooks from this PR and enure that they work as expected.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@Fiona-Waters Fiona-Waters changed the title Updating ray image to use sha rather than floating tag [WIP] Updating ray image to use sha rather than floating tag Sep 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@Fiona-Waters Fiona-Waters changed the title [WIP] Updating ray image to use sha rather than floating tag Updating ray image to use sha rather than floating tag Sep 23, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@Fiona-Waters Fiona-Waters requested review from astefanutti and sutaakar and removed request for MichaelClifford September 23, 2024 11:25
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9a59be8 into project-codeflare:main Sep 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants